| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Neil Conway" <neilc(at)samurai(dot)com> |
| Cc: | "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Added columns to pg_stat_activity |
| Date: | 2005-05-03 07:48:54 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE6C73E1@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> > Looks pretty good -- barring any objections I'll apply this to HEAD
> > tomorrow or the day after (there's a room for a bit of
> cleanup to the
> > docs, but I'll do that before committing).
>
> Couple of minor gripes:
>
> 1. Can we reduce the amount of stuff #include'd by pgstat.h?
> I particularly dislike including builtins.h there; that
> surely should be unnecessary, since there's nothing but
> externs in builtins.h.
Right. Only one needs to be there, the other two can be moved to
pgstatfuncs.c. The last one is needed to get the SockAddr structure.
> 2. WRT the inet.h change: the project standard is that
> extern declarations are spelled with "extern".
Fixed.
Updated patch attached.
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| pgstat3.patch | application/octet-stream | 13.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dawid Kuroczko | 2005-05-03 09:46:41 | Re: Feature freeze date for 8.1 |
| Previous Message | Tom Lane | 2005-05-03 02:02:29 | Re: Added columns to pg_stat_activity |