Re: Added columns to pg_stat_activity

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Added columns to pg_stat_activity
Date: 2005-05-03 02:02:29
Message-ID: 4565.1115085749@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> Looks pretty good -- barring any objections I'll apply this to HEAD
> tomorrow or the day after (there's a room for a bit of cleanup to the
> docs, but I'll do that before committing).

Couple of minor gripes:

1. Can we reduce the amount of stuff #include'd by pgstat.h? I
particularly dislike including builtins.h there; that surely should
be unnecessary, since there's nothing but externs in builtins.h.

2. WRT the inet.h change: the project standard is that extern
declarations are spelled with "extern".

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2005-05-03 07:48:54 Re: Added columns to pg_stat_activity
Previous Message Oliver Jowett 2005-05-03 01:49:56 Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL (was Re: [HACKERS] Feature freeze date for 8.1)