Re: Tsearch2 update for Win32.

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
Cc: "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Tsearch2 update for Win32.
Date: 2004-09-08 14:32:17
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE475C2D@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> >> While I have no particular objection to adjusting the
> >> tsearch2 script, why has the installer got a problem with it?
> >> Seems like this suggests a bug in win32 psql.
>
> > The installer runs contrib module scripts without using psql - it
> > executes them in a 'custom action' - code that is added to the
> > installation package in this case as a dll.
>
> Oh. Hmm ... wouldn't it be easier and safer to launch "psql <script"
> as a subprocess?

I'd say no. Executing processes from the installer environment can be a
headache (we've had enough problems with initdb already..). And you have
to go through all the weirdness with the commandline quoting etc on
win32... It's a lot easier to execute a SQL script line-by-line. Which
also lets us trap the errors easier etc.

//Magnus

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-09-08 14:49:10 Re: Tsearch2 update for Win32.
Previous Message Tom Lane 2004-09-08 14:28:08 Re: Tsearch2 update for Win32.