From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <rhaas(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
Date: | 2017-01-05 17:37:51 |
Message-ID: | 6989.1483637871@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas <rhaas(at)postgresql(dot)org> writes:
> With the old code, a backend that read pg_stat_activity without ever
> having executed a parallel query might see a backend in the midst of
> executing one waiting on a DSA LWLock, resulting in a crash. The
> solution is for backends to register the tranche at startup time, not
> the first time a parallel query is executed.
While I have no objection to the patch as committed, I have to wonder
if this isn't papering over the underlying problem rather than solving it.
It seems like this direction means that there's no such thing as dynamic
registration of LWLock tranches and we should just give up on that concept
entirely. If we do want to preserve the concept, don't we need to fix the
pg_stat_activity code so it doesn't fail on tranches that aren't known
locally?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-01-05 17:44:53 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
Previous Message | Peter Eisentraut | 2017-01-05 17:34:57 | pgsql: Use 'use strict' in all Perl programs |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-01-05 17:44:53 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
Previous Message | Peter Eisentraut | 2017-01-05 17:37:14 | Re: use strict in all Perl programs |