From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: use strict in all Perl programs |
Date: | 2017-01-05 17:37:14 |
Message-ID: | 299783de-6e9f-a105-36dd-b10c71b9e4d1@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/31/16 1:34 AM, Michael Paquier wrote:
> On Sat, Dec 31, 2016 at 3:07 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> Here is a patch to add 'use strict' to all Perl programs (that I could
>> find), or move it to the right place where it was already there. I
>> think that is a pretty standard thing to do nowadays.
committed that
> What about adding as well "use warnings"? That's standard in all the TAP tests.
'use strict' can be statically checked using perl -c, but 'use warnings'
is run-time behavior, so one would have to extensively test the involved
programs. Some cursory checking already reveals that this is going to
need to more investigation. So in principle yes, but maybe later.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-01-05 17:37:51 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
Previous Message | Merlin Moncure | 2017-01-05 17:36:21 | Re: merging some features from plpgsql2 project |