| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ICU bool problem |
| Date: | 2021-07-01 08:59:48 |
| Message-ID: | 698386ef-5401-c6a8-609e-12a89cdf06ae@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.05.21 23:01, Bruce Momjian wrote:
> On Mon, May 17, 2021 at 10:56:54PM +0200, Peter Eisentraut wrote:
>> The fix is like what we used to use for plperl back then:
>>
>> diff --git a/src/include/utils/pg_locale.h b/src/include/utils/pg_locale.h
>> index f3e04d4d8c..499ada2b69 100644
>> --- a/src/include/utils/pg_locale.h
>> +++ b/src/include/utils/pg_locale.h
>> @@ -17,6 +17,9 @@
>> #endif
>> #ifdef USE_ICU
>> #include <unicode/ucol.h>
>> +#ifdef bool
>> +#undef bool
>> +#endif
>> #endif
>>
>> #include "utils/guc.h"
>>
>> I'll prepare a full patch in a bit.
>
> Yes, that seems like a good plan.
I have committed a fix for this.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-07-01 09:07:06 | Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE |
| Previous Message | Fabien COELHO | 2021-07-01 08:50:32 | Re: pgbench logging broken by time logic changes |