Re: ICU bool problem

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ICU bool problem
Date: 2021-05-17 21:01:16
Message-ID: 20210517210116.GB32199@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 17, 2021 at 10:56:54PM +0200, Peter Eisentraut wrote:
> The fix is like what we used to use for plperl back then:
>
> diff --git a/src/include/utils/pg_locale.h b/src/include/utils/pg_locale.h
> index f3e04d4d8c..499ada2b69 100644
> --- a/src/include/utils/pg_locale.h
> +++ b/src/include/utils/pg_locale.h
> @@ -17,6 +17,9 @@
> #endif
> #ifdef USE_ICU
> #include <unicode/ucol.h>
> +#ifdef bool
> +#undef bool
> +#endif
> #endif
>
> #include "utils/guc.h"
>
> I'll prepare a full patch in a bit.

Yes, that seems like a good plan.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-05-17 21:05:44 Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Previous Message Peter Eisentraut 2021-05-17 20:56:54 ICU bool problem