| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: bug in pageinspect's "tuple data" feature |
| Date: | 2020-11-23 07:11:26 |
| Message-ID: | 687d533e-8bba-ef70-68bf-ca56182fb507@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21/11/2020 21:32, Alvaro Herrera wrote:
> If you have a sufficiently broken data page, pageinspect throws an
> error when trying to examine the page:
>
> ERROR: invalid memory alloc request size 18446744073709551451
>
> This is pretty unhelpful; it would be better not to try to print the
> data instead of dying. With that, at least you can know where the
> problem is.
>
> This was introduced in d6061f83a166 (2015). Proposed patch to fix it
> (by having the code print a null "data" instead of dying) is attached.
Null seems misleading. Maybe something like "invalid", or print a warning?
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Lepikhov | 2020-11-23 08:39:00 | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Previous Message | Bharath Rupireddy | 2020-11-23 06:48:42 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |