| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: bug in pageinspect's "tuple data" feature |
| Date: | 2020-11-24 04:01:53 |
| Message-ID: | 20201124040153.GF3046@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 23, 2020 at 09:11:26AM +0200, Heikki Linnakangas wrote:
> On 21/11/2020 21:32, Alvaro Herrera wrote:
>> This is pretty unhelpful; it would be better not to try to print the
>> data instead of dying. With that, at least you can know where the
>> problem is.
>>
>> This was introduced in d6061f83a166 (2015). Proposed patch to fix it
>> (by having the code print a null "data" instead of dying) is attached.
>
> Null seems misleading. Maybe something like "invalid", or print a warning?
How did you get into this state to begin with? get_raw_page() uses
ReadBufferExtended() which gives some level of protection already, so
shouldn't it be better to return an ERROR with ERRCODE_DATA_CORRUPTED
and the block involved?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2020-11-24 04:17:10 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Bharath Rupireddy | 2020-11-24 03:52:58 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |