Re: [PATCH] Fix pg_upgrade test from v10

From: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix pg_upgrade test from v10
Date: 2022-07-31 22:04:39
Message-ID: 67b6b447-e9cb-ebde-4a6b-127aea7ca268@inbox.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello!

On 06.07.2022 08:58, Michael Paquier wrote:

> That's the kind of things I already proposed on this thread, aimed at
> improving the coverage, and this takes care of more issues than what's
> proposed here:
> https://www.postgresql.org/message-id/flat/Yox1ME99GhAemMq1(at)paquier(dot)xyz
> I'll rebase my patch to include fixes for --wal-segsize and
> --allow-group-access when using versions older than v11.
> --
> Michael

Thanks!
I looked at this thread and tried to apply some changes from it in practice.
And found one strange error and describe it in a comment here:
https://www.postgresql.org/message-id/cc7e961a-d5ad-8c6d-574b-478aacc11cf7%40inbox.ru
It would be interesting to know if it occures on
my PC only or somewhere else.

On 05.07.2022 22:08, Justin Pryzby wrote:
>
> ..since it tries to apply all the *.patch files to the master branch, one after
> another. For branches other than master, I suggest to name the patches *.txt
> or similar. Or, just focus for now on allowing upgrades *to* master. I'm not
> sure if anyone is interested in patching test.sh in backbranches. I'm not
> sure, but there may be more interest to backpatch the conversion to TAP
> (322becb60).
>

Yes, the backport idea seems to be interesting. I wrote more about this in a new thread:
https://www.postgresql.org/message-id/e2b1f3a0-4fda-ba72-5535-2d0395b9e68f%40inbox.ru
as the current topic has nothing to do with the backport of TAP tests.

With best regards,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-07-31 22:07:32 Re: ci: update to freebsd 13.1 / remove minor versions from image names
Previous Message Anton A. Melnikov 2022-07-31 22:02:21 [PATCH] Backport perl tests for pg_upgrade from 322becb60