Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, Justin Clift <justin(at)postgresql(dot)org>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Vince Vielhaber <vev(at)michvhf(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in
Date: 2002-08-20 15:28:32
Message-ID: 6772.1029857312@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Nigel J. Andrews" <nandrews(at)investsystems(dot)co(dot)uk> writes:
> But going back to the idea that it seems that the only problem being
> publicised in the 'outside world' is the cash_out(2) version can we
> not do the restriction on acceptable input type in order to claim that
> the fix?

Totally pointless IMHO, when the same problem exists in hundreds of
other functions. Also, there really is no way to patch cash_out per se;
the problem is a system-level problem, namely failure to enforce type
checking. cash_out has no way to know that what it's been passed is the
wrong kind of datum.

Basically, we've used "opaque" as a substitute for accurate type
declarations; that's got to stop.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-08-20 15:32:52 Re: bison news
Previous Message Nigel J. Andrews 2002-08-20 15:22:35 Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in