Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in

From: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, Justin Clift <justin(at)postgresql(dot)org>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Vince Vielhaber <vev(at)michvhf(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in
Date: 2002-08-20 15:44:20
Message-ID: 20020820154420.GB15885@rice.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 20, 2002 at 11:28:32AM -0400, Tom Lane wrote:
> "Nigel J. Andrews" <nandrews(at)investsystems(dot)co(dot)uk> writes:
> > But going back to the idea that it seems that the only problem being
> > publicised in the 'outside world' is the cash_out(2) version can we
> > not do the restriction on acceptable input type in order to claim that
> > the fix?
>
> Totally pointless IMHO, when the same problem exists in hundreds of
> other functions. Also, there really is no way to patch cash_out per se;
> the problem is a system-level problem, namely failure to enforce type
> checking. cash_out has no way to know that what it's been passed is the
> wrong kind of datum.
>
> Basically, we've used "opaque" as a substitute for accurate type
> declarations; that's got to stop.

Hmm, are there _any_ cases where it's appropriate to call an 'opaque'
function directly from user code? cash_out() and it's kin are type
output functions that are called under controlled conditions, with
backend controlled parameters. Trigger functions also are called with
backend controlled parameters. Is there a 'hack' fix that doesn't allow
opaque returning functions in user-defined locations?

Ross

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-08-20 15:45:37 Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in
Previous Message Joe Conway 2002-08-20 15:37:18 Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow