| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: s_lock.h cleanup |
| Date: | 2001-01-19 03:49:29 |
| Message-ID: | 6698.979876169@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
As long as we're cleaning things up, I would suggest that all the ports
that use gcc assembler be made to declare it uniformly, as
__asm__ __volatile__ ( ... );
As I read the GCC manual, there's some risk of the asm sections getting
moved around in the program flow if they are not marked volatile. Also
we oughta be consistent about using the double-underscore keywords IMHO.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-01-19 03:58:34 | Re: s_lock.h cleanup |
| Previous Message | Tom Lane | 2001-01-19 03:17:49 | Re: charset.htm |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-01-19 03:58:34 | Re: s_lock.h cleanup |
| Previous Message | Bruce Momjian | 2001-01-19 02:58:34 | s_lock.h cleanup |