Re: s_lock.h cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: s_lock.h cleanup
Date: 2001-01-19 03:58:34
Message-ID: 200101190358.WAA08973@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Done and applied.

> As long as we're cleaning things up, I would suggest that all the ports
> that use gcc assembler be made to declare it uniformly, as
>
> __asm__ __volatile__ ( ... );
>
> As I read the GCC manual, there's some risk of the asm sections getting
> moved around in the program flow if they are not marked volatile. Also
> we oughta be consistent about using the double-underscore keywords IMHO.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-01-19 04:07:04 Re: Re: postgres TODO
Previous Message Tom Lane 2001-01-19 03:49:29 Re: s_lock.h cleanup

Browse pgsql-patches by date

  From Date Subject
Next Message Peter T Mount 2001-01-19 08:55:53 Re: [PATCHES] Re: Fixes and enhancements to JDBC driver (take 2)
Previous Message Tom Lane 2001-01-19 03:49:29 Re: s_lock.h cleanup