MSVC buildfarm critters are not running modules' TAP tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: MSVC buildfarm critters are not running modules' TAP tests
Date: 2019-09-08 16:07:56
Message-ID: 6628.1567958876@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed $subject while checking to see if commit db4383189's
new test script was behaving properly in the buildfarm. dory,
for one, should be running it but it just isn't.

It looks to me like the reason is that src/tools/msvc/vcregress.pl's
subroutine subdircheck isn't considering the possibility that
subdirectories of src/test/modules contain TAP tests. The
same code is used for contrib, so several existing TAP tests
are being missed there too.

I took a stab at fixing this, but lacking a Windows environment
to test in, I can't be sure if it works. The attached does kinda
sorta work if I run it in a Linux environment --- but I found that
system() doesn't automatically expand "t/*.pl" on Linux. Is that
an expected difference between Linux and Windows perl? I hacked
around that by adding a glob() call in sub tap_check, as seen in
the first hunk below, but I'm not very sure if that hunk should
get committed or not.

For ease of review, I did not re-indent the main part of sub
subdircheck, though that needs to be done before committing.

Anybody with suitable tools care to test/commit this?

regards, tom lane

Attachment Content-Type Size
make-vcregress-run-all-tap-tests-1.patch text/x-diff 2.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-09-08 17:46:13 Re: Python versions (was Re: RHEL 8.0 build)
Previous Message Peter Eisentraut 2019-09-08 13:46:58 Re: Python versions (was Re: RHEL 8.0 build)