Re: MSVC buildfarm critters are not running modules' TAP tests

From: Christoph Moench-Tegeder <cmt(at)burggraben(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Date: 2019-09-08 17:53:49
Message-ID: 20190908175349.GA2466@elch.exwg.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

## Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us):

> I took a stab at fixing this, but lacking a Windows environment
> to test in, I can't be sure if it works. The attached does kinda
> sorta work if I run it in a Linux environment --- but I found that
> system() doesn't automatically expand "t/*.pl" on Linux. Is that
> an expected difference between Linux and Windows perl?

At least the behaviour on Linux (or any unix) is expected: if you pass
a list to perl's system(), perl does not run the command under a shell
(a shell is only invoked if there's only a scalar argument to system()
(or if the list has only one element) and that argument contains shell
metacharacters). That's a source of no small amount "fun" for perl
programms "shelling out", because "sometimes" there is no shell.
Perl's system hase some more caveats, "perldoc -f system" has a
starter on that topic.

Regards,
Christoph

--
Spare Space

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2019-09-08 18:42:55 Re: having issues with PG12 debian packaging repository
Previous Message Tom Lane 2019-09-08 17:46:13 Re: Python versions (was Re: RHEL 8.0 build)