| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | tomas(dot)vondra(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Unbreak recovery test on Windows |
| Date: | 2021-03-21 18:32:28 |
| Message-ID: | 65507be5-4e1f-38b5-bfda-3ce8b988dfc5@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/21/21 2:16 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Ugh. Is there any reason we need to do those kills before we end the
>> psql processes? If not I'm tempted just to move them - after the psql's
>> are finished it should be safe. At any rate I'll go and test that.
> IIUC, that'd completely destroy the point of the test, which is to make
> sure we clean up when a backend dies unexpectedly. If we allow the
> psql's to exit then the backend might be able to complete normal cleanup
> before we can SIGKILL it.
>
> Probably the best thing for now is to revert your change and instead
> just skip the whole test script on Windows.
>
>
OK, will do that.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-03-21 19:13:12 | pgsql: Don't run recover crash_temp_files test in Windows perl |
| Previous Message | Tom Lane | 2021-03-21 18:16:41 | Re: pgsql: Unbreak recovery test on Windows |