Re: pgsql: Unbreak recovery test on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: tomas(dot)vondra(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Unbreak recovery test on Windows
Date: 2021-03-21 18:16:41
Message-ID: 387848.1616350601@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Ugh.  Is there any reason we need to do those kills before we end the
> psql processes? If not I'm tempted just to move them - after the psql's
> are finished it should be safe. At any rate I'll go and test that.

IIUC, that'd completely destroy the point of the test, which is to make
sure we clean up when a backend dies unexpectedly. If we allow the
psql's to exit then the backend might be able to complete normal cleanup
before we can SIGKILL it.

Probably the best thing for now is to revert your change and instead
just skip the whole test script on Windows.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2021-03-21 18:32:28 Re: pgsql: Unbreak recovery test on Windows
Previous Message Alvaro Herrera 2021-03-21 17:57:13 pgsql: Fix new memory leaks in libpq