Re: Printing window function OVER clauses in EXPLAIN

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Printing window function OVER clauses in EXPLAIN
Date: 2025-03-10 01:13:28
Message-ID: 641586.1741569208@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> What are your thoughts on being a bit more brief with the naming and
> just prefix with "w" instead of "window"? Looking at window.out, I see
> that the EXPLAIN output does become quite a bit wider than before. I
> favour the idea of saving a bit of space. There is an example in
> src/sgml/advanced.sgml that has "OVER w", so it does not seem overly
> strange to me to name them "w1", "w2", etc.

OK by me, any objections elsewhere?

>> * In passing, I editorialized on the order in which the Run Condition
>> annotation comes out:

> I did it that way because "Rows Removed by Filter" is a property of
> "Filter", so it makes sense to me for those to be together. It doesn't
> make sense to me to put something unrelated between them.

Hmm, OK. Do you think it could be sensible to put Run Condition
before Filter, then? On the same grounds of "keeping related
things together", it could be argued that Run Condition is
related to the Window property. Also, the Run Condition acts
before the Filter does, if I've got my head screwed on straight.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-03-10 01:14:01 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Previous Message Michael Paquier 2025-03-10 00:23:50 Re: [BUG]: the walsender does not update its IO statistics until it exits