| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows build warnings |
| Date: | 2021-11-27 13:55:29 |
| Message-ID: | 63e35735-6034-9d65-8c3e-7e63fe40b78c@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/26/21 15:14, Daniel Gustafsson wrote:
>> On 26 Nov 2021, at 20:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> I think our policy is to suppress unused-variable warnings if they
>> appear on current mainstream compilers; and it feels a little churlish
>> to deem MSVC non-mainstream. So I stick with my previous suggestion,
>> which basically was to disable C4101 until such time as somebody can
>> make PG_USED_FOR_ASSERTS_ONLY work correctly on MSVC. In the worst
>> case, that might lead a Windows-based developer to submit a patch that
>> draws warnings elsewhere ... but the cfbot, other developers, or the
>> buildfarm will find such problems soon enough.
> I agree with that, and can go make that happen.
>
[trust I have attributions right]
ISTM the worst case is that there will be undetected unused variables in
Windows-only code. I guess that would mostly be detected by Msys systems
running gcc.
Anyway I don't think it's worth arguing a lot about.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arne Roland | 2021-11-27 16:33:07 | Enforce work_mem per worker |
| Previous Message | Marcos Pegoraro | 2021-11-27 12:44:36 | Re: pg_upgrade and publication/subscription problem |