Re: Windows build warnings

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Windows build warnings
Date: 2021-11-30 13:13:43
Message-ID: 61805E2D-B0C4-4F9E-BDDC-989CE12984E8@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Nov 2021, at 14:55, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

> ISTM the worst case is that there will be undetected unused variables in
> Windows-only code. I guess that would mostly be detected by Msys systems
> running gcc.

Yes, that should be caught there. I've applied this now together with the
removal of PG_USED_FOR_ASSERTS_ONLY on those variables where it was set on
variables in general use.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-11-30 13:38:40 Re: Skipping logical replication transactions on subscriber side
Previous Message Simon Riggs 2021-11-30 12:19:00 Re: suboverflowed subtransactions concurrency performance optimize