Re: Documentation building broken in CFBot

I wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> How about this patch.

> This looks like it probably works as far as the actual build goes, but
> could we change configure's call of xmllint likewise? On a lot of my test
> machines (where, as a rule, I don't install DocBook; but xmllint may exist
> anyway), that probe for the docbook DTDs is the slowest step in configure,
> and not by a small margin.

> Actually, I kinda wonder why we bother probing for that at all; it doesn't
> look like anything is done with have_docbook.

This came up again today on another thread [1], so I took a second look
and confirmed that configure's test is completely dead code. So here is
a patch to remove it outright, mooting the question of whether it ought
to use --no-net.

After removing PGAC_CHECK_DOCBOOK, there wasn't much left of docbook.m4,
and what there was had little to do with docbook; so I chose to just
remove that file altogether.

This is actually entirely independent of Peter's patch. I'm tempted
to propose that we could back-patch it and thereby save some configure
cycles for developers, since it has no impact on anybody's build
process.

regards, tom lane

[1] https://www.postgresql.org/message-id/flat/A55A7FC9-FA60-47FE-98B5-139CDC57CE6E%40gmail.com