Hi!
On 03.09.2024 12:52, Andrei Lepikhov wrote:
>> If OR constants have different types, then they belong to different
>> groups, and I think that's unfair. I think that conversion to a
>> single type should be used here - while I’m working on this, I’ll
>> send the code in the next letter.
> IMO, that means additional overhead, isn't it? It is an improvement
> and I suggest to discuss it in a separate thread if current feature
> will be applied.
I think we will have a slight overhead, so in essence it will go
additionally through the transformed groups, and not through the entire
list of Or expressions. I agree with your suggestion to discuss it in
separate thread.
>>
>> And I noticed that there were some tests missing on this, so I added
>> this.
>>
>> I've updated the patch file to include my and Jian's suggestions, as
>> well as the diff file if there's no objection.
> I doubt if you really need additional index on the tenk1 table. What
> is the case you can't reproduce with current indexes, playing, let's
> say, with casting to numeric and integer data types?
> See in attachment minor fixes to the v38 version of the patch set.
>
I rewrote the tests with integer types. Thanks for your suggestion. If
you don't mind, I've updated the diff file you attached earlier to
include the tests.