Re: [PATCH] Covering SPGiST index

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Covering SPGiST index
Date: 2020-08-08 08:44:56
Message-ID: 61AB67A9-6A4D-45D2-A571-9892749AF67B@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 7 авг. 2020 г., в 16:59, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> написал(а):
>
> As usual I very much appreciate your feedback

Thanks for the patch! Looks interesting.

On a first glance the whole concept of non-multicolumn index with included attributes seems...well, just difficult to understand.
But I expect for SP-GiST this must be single key with multiple included attributes, right?
I couldn't find a test that checks impossibility of on 2-column SP-GiST, only few asserts about it. Is this checked somewhere else?

Thanks!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-08-08 09:52:50 Re: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Andrey M. Borodin 2020-08-08 08:35:09 Re: Should the nbtree page split REDO routine's locking work more like the locking on the primary?