Re: Should the nbtree page split REDO routine's locking work more like the locking on the primary?

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should the nbtree page split REDO routine's locking work more like the locking on the primary?
Date: 2020-08-08 08:35:09
Message-ID: 1EB83B5A-B243-4278-AE8F-5F8C4DB9B15F@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 8 авг. 2020 г., в 03:28, Peter Geoghegan <pg(at)bowt(dot)ie> написал(а):
>
> On Thu, Aug 6, 2020 at 7:00 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>> On Thu, Aug 6, 2020 at 6:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> +1 for making this more like what happens in original execution ("on the
>>> primary", to use your wording). Perhaps what you suggest here is still
>>> not enough like the original execution, but it sounds closer.
>>
>> It won't be the same as the original execution, exactly -- I am only
>> thinking of holding on to same-level page locks (the original page,
>> its new right sibling, and the original right sibling).
>
> I pushed a commit that reorders the lock acquisitions within
> btree_xlog_unlink_page() -- they're now consistent with _bt_split()
> (at least among sibling pages involved in the page split).

Sounds great, thanks!

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2020-08-08 08:44:56 Re: [PATCH] Covering SPGiST index
Previous Message Peter Eisentraut 2020-08-08 07:45:27 get rid of distprep?