| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, e(dot)indrupskaya(at)postgrespro(dot)ru |
| Subject: | Re: SQL/JSON revisited |
| Date: | 2023-03-29 18:00:00 |
| Message-ID: | 60483139-5c34-851d-baee-6c0d014e1710@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
29.03.2023 13:27, Alvaro Herrera wrote:
> ... and pushed it now, after some more meddling.
>
> I'll rebase the rest of the series now.
Please look at the several minor issues/inconsistencies,
I've spotted in the commit:
1) s/JSON_ARRRAYAGG/JSON_ARRAYAGG/
2)
check_key_uniqueness vs check_unique
IIUC, these are different names of the same entity.
3)
elog(ERROR, "invalid JsonConstructorExprType %d", ctor->type);
vs
elog(ERROR, "invalid JsonConstructorExpr type %d", ctor->type);
I'd choose the latter spelling as the JsonConstructorExprType entity does not exist.
4)
In the block:
else
{
res = (Datum) 0;
elog(ERROR, "invalid JsonConstructorExpr type %d", ctor->type);
}
res is assigned but never used.
5)
(expr [FORMAT json_format]) ->? (expr [FORMAT JsonFormat])
(json_format not found anywhere else)
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-03-29 18:17:08 | Re: SQL/JSON revisited |
| Previous Message | Alexander Korotkov | 2023-03-29 17:34:10 | Re: POC: Lock updated tuples in tuple_update() and tuple_delete() |