Re: SQL/JSON revisited

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, e(dot)indrupskaya(at)postgrespro(dot)ru
Subject: Re: SQL/JSON revisited
Date: 2023-03-29 18:17:08
Message-ID: 20230329181708.e64g2tpy7jyufqkr@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Mar-29, Alexander Lakhin wrote:

> Hi,
>
> 29.03.2023 13:27, Alvaro Herrera wrote:
> > ... and pushed it now, after some more meddling.
> >
> > I'll rebase the rest of the series now.
>
> Please look at the several minor issues/inconsistencies,
> I've spotted in the commit:

Thanks, I'll look at this tomorrow.

In the meantime, here's the next two patches of the series: IS JSON and
the "query" functions. I think this is as much as I can get done for
this release, so the last two pieces of functionality would have to wait
for 17. I still need to clean these up some more. These are not
thoroughly tested either; 0001 compiles and passes regression tests, but
I didn't verify 0003 other than there being no Git conflicts and bison
doesn't complain.

Also, notable here is that I realized that I need to backtrack on my
change of the WITHOUT_LA: the original patch had it for TIME (in WITHOUT
TIME ZONE), and I changed to be for UNIQUE. But now that I've done
"JSON query functions" I realize that it needed to be the other way for
the WITHOUT ARRAY WRAPPER clause too. So 0002 reverts that choice.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Crear es tan difícil como ser libre" (Elsa Triolet)

Attachment Content-Type Size
v13-0001-IS-JSON-predicate.patch text/x-diff 48.1 KB
v13-0002-backtrack-on-making-WITHOUT_LA-be-for-UNIQUE-rat.patch text/x-diff 2.7 KB
v13-0003-SQL-JSON-query-functions.patch text/x-diff 202.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karl O. Pinc 2023-03-29 18:23:33 Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Previous Message Alexander Lakhin 2023-03-29 18:00:00 Re: SQL/JSON revisited