Re: Review: listagg aggregate

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Scott Bailey <artacus(at)comcast(dot)net>, "pgsql-hackers(at)postgresql(dot)org Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: listagg aggregate
Date: 2010-01-26 14:15:35
Message-ID: 603c8f071001260615q4ea3dec1xe33da54806241085@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 26, 2010 at 2:14 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 2010/1/25 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> On Mon, Jan 25, 2010 at 2:27 PM, David E. Wheeler <david(at)kineticode(dot)com> wrote:
>>> On Jan 25, 2010, at 2:09 AM, Peter Eisentraut wrote:
>>>> xmlagg -> concatenates values to form xml datum
>>>> array_agg -> concatenates values to form array datum
>>>> ??? -> concatenates values to form string datum
>>>
>>> concat_agg().
>>
>> I like that one...
>
> why is concat_agg better than listagg ?

Because it doesn't make lists.

Honestly, I don't love concat_agg() either - why should something need
to have agg in the name just because it's an aggregate? I think the
most descriptive name would be something like
concatenate_with_separator(), but that's kind of long.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-01-26 14:18:33 Re: Dividing progress/debug information in pg_standby, and stat before copy
Previous Message Merlin Moncure 2010-01-26 14:13:09 Review of Writeable CTE Patch