| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: to_char, support for EEEE format |
| Date: | 2009-07-30 16:29:59 |
| Message-ID: | 603c8f070907300929j249448d7md5e1498ab264ceab@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 30, 2009 at 12:17 PM, Euler Taveira de
Oliveira<euler(at)timbira(dot)com> wrote:
> Brendan Jurd escreveu:
>> I can't imagine anyone reading the code getting confused about this,
>> and don't know how to go about writing a comment explaining something
>> that is intuitively obvious to me. I don't understand what aspect of
>> it requires explanation. The test is not in the switch because it
>> doesn't belong there.
>>
> It was just a suggestion. If you think it is self-explanatory, so it is. But I
> (as the first time reading that piece of code) take some time to figure out
> why that test is outside the switch.
I don't think we should worry about this particular issue too much.
If the biggest problem this patch has is whether or not this deserves
a comment, we're doing well; the committer can (and doubtless will)
adjust that as they may see fit.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-07-30 16:31:39 | Re: WIP: to_char, support for EEEE format |
| Previous Message | Euler Taveira de Oliveira | 2009-07-30 16:17:49 | Re: WIP: to_char, support for EEEE format |