Re: WIP: to_char, support for EEEE format

From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: to_char, support for EEEE format
Date: 2009-07-30 16:17:49
Message-ID: 4A71C7AD.6020801@timbira.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Brendan Jurd escreveu:
> I can't imagine anyone reading the code getting confused about this,
> and don't know how to go about writing a comment explaining something
> that is intuitively obvious to me. I don't understand what aspect of
> it requires explanation. The test is not in the switch because it
> doesn't belong there.
>
It was just a suggestion. If you think it is self-explanatory, so it is. But I
(as the first time reading that piece of code) take some time to figure out
why that test is outside the switch.

--
Euler Taveira de Oliveira
http://www.timbira.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-07-30 16:29:59 Re: WIP: to_char, support for EEEE format
Previous Message Euler Taveira de Oliveira 2009-07-30 16:14:25 Re: WIP: to_char, support for EEEE format