| From: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: Failure in contrib test _int on loach |
| Date: | 2019-04-29 13:16:22 |
| Message-ID: | 5d48ce28-34cf-9b03-5d42-dbd5457926bf@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
27.04.2019 22:05, Tom Lane wrote:
> Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> writes:
>> So it is possible, but it doesn't require any extra algorithm changes.
>> I didn't manage to generate dataset to reproduce grandparent split.
>> Though, I do agree that it's worth checking out. Do you have any ideas?
> Ping? This thread has gone cold, but the bug is still there, and
> IMV it's a beta blocker.
Hi,
Thank you for the reminder.
In a nutshell, this fix is ready for committer.
In previous emails, I have sent two patches with test and bugfix (see
attached).
After Heikki shared his concerns, I've rechecked the algorithm and
haven't found any potential error.
So, if other hackers are agreed with my reasoning, the suggested fix is
sufficient and can be committed.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| gist_optimized_wal_intarray_fix_v1.patch | text/x-patch | 2.1 KB |
| gist_optimized_wal_intarray_test_v1.patch | text/x-patch | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2019-04-29 13:35:12 | Re: Plain strdup() in frontend code |
| Previous Message | Alvaro Herrera | 2019-04-29 13:03:21 | Re: Refactoring the checkpointer's fsync request queue |