| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-08-12 15:57:25 |
| Message-ID: | 5a40cc37-3cae-b3c3-1435-04292cabf298@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-08-11 Fr 19:17, Tom Lane wrote:
> Peter Geoghegan<pg(at)bowt(dot)ie> writes:
>> I'm starting to have doubts about this policy. There have now been
>> quite a few follow-up "fixes" to indentation issues that koel
>> complained about. None of these fixups have been included in
>> .git-blame-ignore-revs. If things continue like this then "git blame"
>> is bound to become much less usable over time.
> FWIW, I'm much more optimistic than that. I think what we're seeing
> is just the predictable result of not all committers having yet
> incorporated "pgindent it before committing" into their workflow.
> The need for followup fixes should diminish as people start doing
> that. If you want to hurry things along, peer pressure on committers
> who clearly aren't bothering is the solution.
Yeah, part of the point of creating koel was to give committers a bit of
a nudge in that direction.
With a git pre-commit hook it's pretty painless.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-08-12 16:07:47 | Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION } |
| Previous Message | Bruce Momjian | 2023-08-12 15:30:55 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |