| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Using read_stream in index vacuum |
| Date: | 2025-03-18 18:20:55 |
| Message-ID: | 5F88CEBF-8518-4062-ACC6-8216684FD70E@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 18 Mar 2025, at 20:37, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
>
> I've reviewed 0001
Thanks!
I've added all suggested fixes as a separate patch step.
Except I did not rename injection points... I can't figure out descriptive names.
And delay point is now after the page is processed, not before.
FWIW I do not insist on committing the test, it was mostly necessary to validate that backtracking still works. I could not check it manually. But other injection tests, surprisingly, seem to be stable enough across buildfarm.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Prototype-B-tree-vacuum-streamlineing.patch | application/octet-stream | 9.2 KB |
| v9-0004-Use-read_stream-in-SP-GiST-vacuum.patch | application/octet-stream | 3.2 KB |
| v9-0003-Use-read_stream-in-GiST-vacuum.patch | application/octet-stream | 4.3 KB |
| v9-0002-Review-fixes.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-03-18 18:21:50 | Re: Using read_stream in index vacuum |
| Previous Message | Tom Lane | 2025-03-18 17:55:32 | Re: Add -k/--link option to pg_combinebackup |