From: | Chapman Flack <chap(at)anastigmatix(dot)net> |
---|---|
To: | Kartik Ohri <kartikohri13(at)gmail(dot)com> |
Cc: | pljava-dev(at)lists(dot)postgresql(dot)org |
Subject: | Re: the ReportScriptingMojo |
Date: | 2020-08-14 12:28:48 |
Message-ID: | 5F368380.9070203@anastigmatix.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pljava-dev |
Hi Kartik,
I've made a pull request onto your 'plugin' branch. The first three
commits are some small fixes; you'll probably want to review those to
see what the issues were. The rest deals with getting the javadoc links
from one submodule to another to be generated correctly and in relative
form, so the output tree can be relocated and still work. That has been
a sticking point for years the old way, so I am glad to be able to fix it
now.
I think that if you merge that PR, that branch will be ready for a PR
onto master in the main repo. As a matter of form, it might be best to
create a new branch name, at the same point, according to the conventions
in the contribution guide [1], something like feature/master/scriptreports,
and use that branch in the pull request.
Regards,
-Chap
From | Date | Subject | |
---|---|---|---|
Next Message | Kartik Ohri | 2020-08-14 12:39:10 | Re: the ReportScriptingMojo |
Previous Message | Kartik Ohri | 2020-08-14 02:44:55 | Re: PL/Java new build plugin |