| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | btnakamurakoukil <btnakamurakoukil(at)oss(dot)nttdata(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c |
| Date: | 2024-09-24 12:31:30 |
| Message-ID: | 5DCA3F10-18DF-4824-8557-7F6C9295810E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Sep 2024, at 10:32, btnakamurakoukil <btnakamurakoukil(at)oss(dot)nttdata(dot)com> wrote:
> I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think?
That variable does indeed seem to not be used, and hasn't been used since it
was committed in d168b666823. The question is if it's a left-over from
development which can be removed, or if it should be set and we're missing an
optimization. Having not read the referenced paper I can't tell so adding
Peter Geoghegan who wrote this for clarification.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alastair Turner | 2024-09-24 12:53:49 | Re: Add llvm version into the version string |
| Previous Message | Srirama Kucherlapati | 2024-09-24 11:25:35 | RE: AIX support |