[pgjdbc/pgjdbc] f0deab: fix: named statements were used when fetchSize was...

From: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org
Subject: [pgjdbc/pgjdbc] f0deab: fix: named statements were used when fetchSize was...
Date: 2017-07-24 12:57:15
Message-ID: 5975eeabd2e92_32503fb4bc4b3c2c32397@hookshot-fe5-cp1-prd.iad.github.net.mail
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Branch: refs/heads/master
Home: https://github.com/pgjdbc/pgjdbc
Commit: f0deabf7d87bb5bffeb84e9cd686eeb632aa9687
https://github.com/pgjdbc/pgjdbc/commit/f0deabf7d87bb5bffeb84e9cd686eeb632aa9687
Author: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
Date: 2017-07-24 (Mon, 24 Jul 2017)

Changed paths:
M pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java
A pgjdbc/src/test/java/org/postgresql/test/jdbc2/ConcurrentStatementFetch.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc2/Jdbc2TestSuite.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java

Log Message:
-----------
fix: named statements were used when fetchSize was non-zero and prepareThreshold=0 (#870)

Non-zero fetchSize triggers use of named portals (for subsequent fetch requests),
however named portals does not require to use named statements.

As per PostgreSQL documentation, named portals are automatically closed as transaction completes, so named portals should play well with transaction-based poolers.

fixes #869

Browse pgsql-jdbc by date

  From Date Subject
Next Message Vladimir Sitnikov 2017-07-24 21:13:51 [pgjdbc/pgjdbc] 5334cb: test: skip ConcurrentStatementFetch for PostgreSQL...
Previous Message Michael Glaesemann 2017-07-24 09:41:28 [pgjdbc/pgjdbc] 8287e7: test: assume integer datetimes for timestamp tests...