[pgjdbc/pgjdbc] 8287e7: test: assume integer datetimes for timestamp tests...

From: Michael Glaesemann <grzm(at)seespotcode(dot)net>
To: pgsql-jdbc(at)postgresql(dot)org
Subject: [pgjdbc/pgjdbc] 8287e7: test: assume integer datetimes for timestamp tests...
Date: 2017-07-24 09:41:28
Message-ID: 5975c0c8b064a_16823f89e433dc38107911@hookshot-fe3-cp1-prd.iad.github.net.mail
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Branch: refs/heads/master
Home: https://github.com/pgjdbc/pgjdbc
Commit: 8287e7f92f890a41f8d2b51980157a92e1cd57e8
https://github.com/pgjdbc/pgjdbc/commit/8287e7f92f890a41f8d2b51980157a92e1cd57e8
Author: Michael Glaesemann <grzm(at)seespotcode(dot)net>
Date: 2017-07-24 (Mon, 24 Jul 2017)

Changed paths:
M pgjdbc/src/test/java/org/postgresql/test/TestUtil.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGTimeTest.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGTimestampTest.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimestampTest.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc42/GetObject310Test.java
M pgjdbc/src/test/java/org/postgresql/test/jdbc42/SetObject310Test.java

Log Message:
-----------
test: assume integer datetimes for timestamp tests (#873)

Float timestamp equality comparisons like comparisons with any float
are problematic if they don't take into account their imprecise
nature. Some timestamp tests produce false negative failures for
servers compiled with float timestamps. Use JUnit assumptions to skip
these tests if the server doesn't have integer datetimes.

This addresses https://github.com/pgjdbc/pgjdbc/issues/12 in part in
that it omits (most of) the failing tests, though it leaves these
timestamp behaviors untested under float timestamps, which was the
default prior to PostgreSQL 8.4.

Browse pgsql-jdbc by date

  From Date Subject
Next Message Vladimir Sitnikov 2017-07-24 12:57:15 [pgjdbc/pgjdbc] f0deab: fix: named statements were used when fetchSize was...
Previous Message Vladimir Sitnikov 2017-07-23 21:08:09 [pgjdbc/pgjdbc] ed0014: test: make StringTypeParameterTest 8.3+ since 8.2 ...