| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | James Inform <james(dot)inform(at)pharmapp(dot)de>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com> |
| Subject: | Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation |
| Date: | 2022-08-14 06:15:45 |
| Message-ID: | 587801.1660457745@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
... BTW, I wondered how come we'd missed noticing such a serious problem
in any testing. The code coverage report at
https://coverage.postgresql.org/src/backend/utils/adt/varlena.c.gcov.html
says that only the "if (sss->collate_c)" path in varstr_abbrev_convert
gets exercised in our regression tests. I thought maybe that just
meant that the coverage.postgresql.org run uses C locale, but I see
the same lack-of-coverage in a local test under LANG=en_US.utf8.
How can we only be reaching this function with sss->collate_c true
when the prevailing locale isn't that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-08-14 06:31:06 | Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation |
| Previous Message | Tom Lane | 2022-08-14 04:10:55 | Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation |