Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: James Inform <james(dot)inform(at)pharmapp(dot)de>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>
Subject: Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
Date: 2022-08-14 04:10:55
Message-ID: 559703.1660450255@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Sat, Aug 13, 2022 at 8:21 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hmm, but if we're enlarging the buffer, doesn't that imply
>> a new input value? Seems like invalidation must occur anyway.

> Yeah, on second thought it should be invalidated anyway (I had to
> check because the details of how we cache strxfrm() and strcoll() are
> tricky). Even still, I think that we should just use repalloc for
> this.

Works for me. I'll see about pushing the fix tomorrow. Thanks
for the additional investigation!

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2022-08-14 06:15:45 Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
Previous Message Peter Geoghegan 2022-08-14 03:55:46 Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation