| From: | "Li, Yong" <yoli(at)ebay(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive modules loose ends |
| Date: | 2024-01-15 12:21:44 |
| Message-ID: | 5810C4B0-EDE0-4504-AB66-0DBFB79F690E@ebay.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 29, 2023, at 01:18, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> External Email
>
> Here is a new version of the patch with feedback addressed.
>
> --
> Nathan Bossart
> Amazon Web Services: https://aws.amazon.com
Hi Nathan,
The patch looks good to me. With the context explained in the thread, the patch is easy to understand.
The patch serves as a refactoring which pulls up common memory management and error handling concerns into the pgarch.c. With the patch, individual archive callbacks can focus on copying the files and leave the boilerplate code to pgarch.c.
The patch applies cleanly to HEAD. “make check-world” also runs cleanly with no error.
Regards,
Yong
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-01-15 12:43:03 | Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c) |
| Previous Message | Alvaro Herrera | 2024-01-15 12:03:51 | Re: Lockless exit path for ReplicationOriginExitCleanup |