| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Li, Yong" <yoli(at)ebay(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive modules loose ends |
| Date: | 2024-01-15 14:50:25 |
| Message-ID: | 20240115145025.GA4183171@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 15, 2024 at 12:21:44PM +0000, Li, Yong wrote:
> The patch looks good to me. With the context explained in the thread,
> the patch is easy to understand.
> The patch serves as a refactoring which pulls up common memory management
> and error handling concerns into the pgarch.c. With the patch,
> individual archive callbacks can focus on copying the files and leave the
> boilerplate code to pgarch.c..
>
> The patch applies cleanly to HEAD. “make check-world” also runs cleanly
> with no error.
Thanks for reviewing. I've marked this as ready-for-committer, and I'm
hoping to commit it in the near future.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-01-15 15:08:05 | Re: Custom explain options |
| Previous Message | Jelte Fennema-Nio | 2024-01-15 14:40:30 | Re: Add test module for Table Access Method |