| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Michael Banck <mbanck(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_checksums: Reorder headers in alphabetical order |
| Date: | 2024-09-21 02:55:53 |
| Message-ID: | 57e73d47-c5a7-4aec-9e01-8ad87b1be7e0@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/09/21 5:20, Nathan Bossart wrote:
> On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote:
>> On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
>>> I noticed two headers are not in alphabetical order in pg_checkums.c,
>>> patch attached.
>>
>> This appears to be commit 280e5f1's fault. Will fix.
>
> Committed, thanks!
I don’t have any objections to this commit, but I’d like to confirm
whether we really want to proactively reorder #include directives,
even for standard C library headers. I’m asking because I know there are
several source files, like xlog.c and syslogger.c, where such #include
directives aren't in alphabetical order. I understand we usually reorder
#include directives for PostgreSQL header files, though.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-21 03:09:17 | Re: pg_checksums: Reorder headers in alphabetical order |
| Previous Message | John H | 2024-09-21 01:04:24 | Re: Allow logical failover slots to wait on synchronous replication |