| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inaccurate error message when set fdw batch_size to 0 |
| Date: | 2021-05-10 06:30:23 |
| Message-ID: | 577121.1620628223@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> +1 for the change of the error messages.
Yeah, this error message seems outright buggy. However, it's a minor
matter. Also, some people think "positive" is the same thing as
"non-negative", so maybe we need less ambiguous wording?
> One question is; should we back-patch the change of the error message about
> fetch_size to back branches? Since this is minor thing, is it enough to apply
> the change only to the master? Even if we should do the back-patch,
> we would need to wait until upcoming minor release is done before doing that.
+1 for back-patch, but not till after the releases are out. Right now
is no time for inessential changes ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-10 06:32:01 | Re: strange case of "if ((a & b))" |
| Previous Message | Michael Paquier | 2021-05-10 06:27:13 | Re: strange case of "if ((a & b))" |