| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inaccurate error message when set fdw batch_size to 0 |
| Date: | 2021-05-10 06:17:28 |
| Message-ID: | 1d27d8f1-123a-3d3e-cd71-e253b80efdb9@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/05/10 10:26, tsunakawa(dot)takay(at)fujitsu(dot)com wrote:
> From: houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com>
>> So, is it better to change the error message to “fetch_size requires a positive integer value” ?
>> I also found fetch_size has the similar issue, attaching a patch to fix this.
>
> I have a faint memory that I fixed them after receiving the same feedback from someone else, strange... Anyway, thanks.
+1 for the change of the error messages.
One question is; should we back-patch the change of the error message about
fetch_size to back branches? Since this is minor thing, is it enough to apply
the change only to the master? Even if we should do the back-patch,
we would need to wait until upcoming minor release is done before doing that.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-10 06:25:08 | Re: strange case of "if ((a & b))" |
| Previous Message | Laurenz Albe | 2021-05-10 06:16:16 | Re: PG 14 release notes, first draft |