Rename libpq trace internal functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Rename libpq trace internal functions
Date: 2024-04-24 07:39:02
Message-ID: 575e4f9d-acfe-45e3-b7f1-7e32c579090e@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

libpq's pqTraceOutputMessage() used to look like this:

case 'Z': /* Ready For Query */
pqTraceOutputZ(conn->Pfdebug, message, &logCursor);
break;

Commit f4b54e1ed98 introduced macros for protocol characters, so now
it looks like this:

case PqMsg_ReadyForQuery:
pqTraceOutputZ(conn->Pfdebug, message, &logCursor);
break;

But this introduced a disconnect between the symbol in the switch case
and the function name to be called, so this made the manageability of
this file a bit worse.

This patch changes the function names to match, so now it looks like
this:

case PqMsg_ReadyForQuery:
pqTraceOutput_ReadyForQuery(conn->Pfdebug, message, &logCursor);
break;

(This also improves the readability of the file in general, since some
function names like "pqTraceOutputt" were a little hard to read
accurately.)

Some protocol characters have different meanings to and from the
server. The old code structure had a common function for both, for
example, pqTraceOutputD(). The new structure splits this up into
separate ones to match the protocol message name, like
pqTraceOutput_Describe() and pqTraceOutput_DataRow().

Attachment Content-Type Size
0001-Rename-libpq-trace-internal-functions.patch text/plain 15.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-04-24 07:51:07 Re: Feature request: schema diff tool
Previous Message Michael Paquier 2024-04-24 07:28:21 Re: Cleanup: remove unused fields from nodes