Re: [patch] fix buffer overrun in logging, and code cleanup

From: "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-odbc(at)postgresql(dot)org" <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: [patch] fix buffer overrun in logging, and code cleanup
Date: 2016-05-27 07:54:24
Message-ID: 5747FD30.8080600@dream.email.ne.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

Hi,

I would examine the patch.
However forcelog() exists in msdtc_enlist.cpp at first glance.

regards,
Hiroshi Inoue

On 2016/05/26 11:40, Tsunakawa, Takayuki wrote:
> Hello,
>
> While I was troubleshooting some user problem and trying to figure out why mylog_xxx.log is not created, I found a tiny bug. The buffers for holding the full path for MyLog and CommLog are small -- only 80 bytes. If you specify a long path for Logdir, the buffer overrun occurs. Please find the attached patch mylog_buffer_overrun.patch.
>
> The other patch mylog_cleanup.patch removes code which are unused or unnecessary anymore. I'd like to make the code as lean as possible, so that it makes code reading and searching easier and faster. This patch removes about 120 lines.
>
> Regards
> Takayuki Tsunakawa

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Inoue, Hiroshi 2016-05-27 08:04:04 Re: ADO CommandTimeout vs Postgres statement_timeout parameter
Previous Message Cindy Taylor 2016-05-26 23:42:32 ODBC connections