| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | "pgsql-odbc(at)postgresql(dot)org" <pgsql-odbc(at)postgresql(dot)org> |
| Subject: | [patch] fix buffer overrun in logging, and code cleanup |
| Date: | 2016-05-26 02:40:45 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1F57A775@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc |
Hello,
While I was troubleshooting some user problem and trying to figure out why mylog_xxx.log is not created, I found a tiny bug. The buffers for holding the full path for MyLog and CommLog are small -- only 80 bytes. If you specify a long path for Logdir, the buffer overrun occurs. Please find the attached patch mylog_buffer_overrun.patch.
The other patch mylog_cleanup.patch removes code which are unused or unnecessary anymore. I'd like to make the code as lean as possible, so that it makes code reading and searching easier and faster. This patch removes about 120 lines.
Regards
Takayuki Tsunakawa
| Attachment | Content-Type | Size |
|---|---|---|
| mylog_buffer_overrun.patch | application/octet-stream | 631 bytes |
| mylog_cleanup.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2016-05-26 08:27:10 | Re: ADO CommandTimeout vs Postgres statement_timeout parameter |
| Previous Message | Tsunakawa, Takayuki | 2016-05-26 02:10:11 | Re: PostgreSQL: SQLSetPos fails with SetPos update return error. |