Re: 11beta crash/assert caused by parameter type changes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 11beta crash/assert caused by parameter type changes
Date: 2018-07-26 19:20:08
Message-ID: 562.1532632808@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Jul 26, 2018 at 2:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I was about to add Andrew's example as a test case (also shown in
>> attached), but realized that there's a problem: just as noted in
>> the similar test for named-composite-type changes a bit above there,
>> the failure fails to fail in CLOBBER_CACHE_ALWAYS builds.

> Sorry if this is a dumb question, but why does that happen? I thought
> that the idea was that CLOBBER_CACHE_ALWAYS shouldn't change
> semantics.

What we need to fix the problem properly is to forcibly replan a
plancache entry when the type of one of the query's input parameters
changes. If you turn on CCA, plancache entries are forcibly replanned
at every use. So, problem goes away (in the most expensive way
possible).

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-07-26 19:27:48 Re: 11beta crash/assert caused by parameter type changes
Previous Message Robert Haas 2018-07-26 19:14:53 Re: 11beta crash/assert caused by parameter type changes