Re: 11beta crash/assert caused by parameter type changes

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 11beta crash/assert caused by parameter type changes
Date: 2018-07-26 19:27:48
Message-ID: 20180726192748.lxig45jdmpbbqhr3@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-07-26 14:06:16 -0400, Tom Lane wrote:
> I was about to add Andrew's example as a test case (also shown in
> attached), but realized that there's a problem: just as noted in
> the similar test for named-composite-type changes a bit above there,
> the failure fails to fail in CLOBBER_CACHE_ALWAYS builds. We'd decided
> to just omit that test (cf feb1cc559) but having been embarrassed by
> this crash I'm feeling like we really could do with some test coverage.
> I'm tempted to extract the affected test cases into their own small
> test script and provide two variant expected files, one for normal and
> one for CLOBBER_CACHE_ALWAYS builds. Thoughts?

Could we perhaps avoid the divergence by prevent a replan, e.g. by using
a cursor and starting the execution of the query before changing the
type? Otherwise I think I'm ok with having an alternative file, as long
as there's a good comment explaining it.

-Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-07-26 19:37:13 Re: 11beta crash/assert caused by parameter type changes
Previous Message Tom Lane 2018-07-26 19:20:08 Re: 11beta crash/assert caused by parameter type changes