| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Warnings around booleans |
| Date: | 2015-08-13 11:27:33 |
| Message-ID: | 55CC7F25.7010406@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Playing around a bit lead to to find that this is caused by a wrong type
> declaration in two places. 'isarray' is declared as bool instead of enum
> ARRAY_TYPE in two places. This appears to be an oversight, perhaps
> caused by the boolean sounding name.
I vaguely remember that it used to be bool back in the day.
> Does this look right to you? If so, will you apply it?
Yes and yes. Thanks for spotting, fixed in master and the back branches.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-08-13 11:28:58 | Re: Warnings around booleans |
| Previous Message | Kouhei Kaigai | 2015-08-13 11:23:19 | Re: Our trial to TPC-DS but optimizer made unreasonable plan |